Skip to content

fix(pr-craft): keep performed manual checks on the Ran line - #11

Merged
galligan merged 1 commit into
mainfrom
fix/skills/pr-craft-manual-checks
Nov 11, 2026
Merged

galligan merged 1 commit into
mainfrom
fix/skills/pr-craft-manual-checks

Conversation

@galligan

@galligan galligan commented Nov 11, 2026 •

Copy link
Copy Markdown
Owner

Fixes how pr-craft carries a manual check into a rewritten PR body: a check the author performed stays on the Ran: line. Only that one rule changes.

Related to #10

Context

When a rewritten body reports a manual check that names its action, such as "clicked Save and saw success", the skill carries the check over as a reviewer step. The observed result becomes an expectation, and the Ran: line no longer shows the check was performed.

Changes

  • A manual check that names its action stays on the Ran: line with its result and can also be offered as a reviewer step, in .skillset/skills/pr-craft/SKILL.md.

Verify

  • Open ## Existing PRs in skills/pr-craft/SKILL.md → the manual-check rule names the Ran: line.
  • Ran: bun run build, bun run check, bun run check:changes --since origin/main, bun run skillset check --only outputs, and git diff --check, all pass. Not verified: no Redliner review ran on this one-sentence change.

Devin Review

A rewrite carried a manual check over as a reviewer step, which turned an observed result into an expectation and dropped it from the Ran line.
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-11T18:20:32.118136Z c5a12c8 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@galligan
galligan merged commit c03ccad into main Nov 11, 2026
2 of 3 checks passed
@galligan
galligan deleted the fix/skills/pr-craft-manual-checks branch November 11, 2026 18:19

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

Devin Review

Comment thread .skillset/skills/pr-craft/SKILL.md Resolved
@linear-code

linear-code Bot commented Nov 11, 2026

Copy link
Copy Markdown

SET-837

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c5a12c8fd1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .skillset/skills/pr-craft/SKILL.md Resolved
galligan added a commit that referenced this pull request Nov 11, 2026
#12)

Fixes a rewritten PR body listing a performed manual check twice: once
on the `Ran:` line and again as a reviewer step. Only that one
`pr-craft` rule changes.

Related to #11

## Context
When `pr-craft` rewrites an existing PR body, a manual check the author
performed, such as "clicked Save and saw success", stays on the `Ran:`
line. The rule also lets the agent offer the same check as a reviewer
step, with no criterion for when. A body that does so states the check
twice, against the rewrite rules to state each fact once and not outgrow
the original.

## Changes
- A performed manual check stays only on the `Ran:` line with its
result, in `.skillset/skills/pr-craft/SKILL.md`. The `Ran:` line already
names the action, so a reviewer can repeat it.

## Verify
- Open `## Existing PRs` in `skills/pr-craft/SKILL.md` → the
manual-check rule ends with "Do not also add it as a reviewer step."
- Ran: a scoped Redliner review of `.skillset/skills/pr-craft/SKILL.md`,
with the generated `skills/pr-craft/SKILL.md` and
`references/examples.md` as context → one low-severity finding, fixed
here; `validate.py` and `consolidate.py` pass. `bun run build`, `bun run
check`, `bun run check:changes --since origin/main`, `bun run skillset
check --only outputs`, and `git diff --check`, all pass. Not verified: a
rewrite of a real PR body under the new rule.

## Open items
- Question (reviewer): Redliner marks this a decision because it removes
the step-form entry. If a step is worth the repetition, the alternative
is to allow it only when the body stays within the original's length.

<!-- devin-review-badge-begin -->

---

<a href="https://app.devin.ai/review/galligan/skills/pull/12"
target="_blank"><picture><source media="(prefers-color-scheme: dark)"
srcset="https://static.devin.ai/assets/gh-devin-review-dark.svg?v=4"><img
src="https://static.devin.ai/assets/gh-devin-review-light.svg?v=4"
alt="Devin Review"></picture></a>
<!-- devin-review-badge-end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant